Return event name from getVendorPrefixedEventName#11951
Merged
aweary merged 1 commit intofacebook:masterfrom Jan 2, 2018
Merged
Return event name from getVendorPrefixedEventName#11951aweary merged 1 commit intofacebook:masterfrom
aweary merged 1 commit intofacebook:masterfrom
Conversation
gaearon
approved these changes
Jan 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of relying on
getVendorPrefixedEventNamereturning an empty string for un-prefixed events, just return the event name. That way we don't have to duplicate the string literals and can remove the||. Saves a few bytes! 📦